Skip to content

Restore old chain dma implementation - #7104

Closed
jsarha wants to merge 3 commits into
thesofproject:mainfrom
jsarha:restore_old_chain_dma_implementation
Closed

jsarha wants to merge 3 commits into
thesofproject:mainfrom
jsarha:restore_old_chain_dma_implementation

Conversation

@jsarha

@jsarha jsarha commented Feb 15, 2023

Copy link
Copy Markdown
Contributor

Just curious if the old version would still pass the whole CI. May also be useful in comparing the logic to find out what goes wrong with the new implementation. But I have no intention of proposing to merge this.

@jsarha

jsarha commented Feb 16, 2023

Copy link
Copy Markdown
Contributor Author

Oh, but I forgot to enable chain dma from the topology.

Resurect the old ipc4_create_pipeline() as ipc4_create_pipeline_old()
for ipc4_create_chain_dma(). This is used by the old chain dma
implementation.

Signed-off-by: Jyri Sarha <jyri.sarha@intel.com>
This reverts commit 19df10f.

This revert restores the old version if chained dma implementation,
which is currently the only version that has ever passed
multiple-pause-resume test.

Signed-off-by: Jyri Sarha <jyri.sarha@intel.com>
The known issues with the pipeline-free chain DMA implementation has
now been solved, so we can re-enable chain DMA usage.

This reverts commit c3807ae.

Signed-off-by: Jyri Sarha <jyri.sarha@intel.com>
@jsarha
jsarha force-pushed the restore_old_chain_dma_implementation branch from ec3ccce to bd70ba5 Compare February 16, 2023 08:51
@gkbldcig

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@jsarha jsarha closed this Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants